Notify startup fail #304
Merged
Notify startup fail #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lodestone-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for lodestone-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CheatCod
requested changes
Jul 16, 2023
|
Is this ready for review again? |
Ynng
reviewed
Jul 24, 2023
Ynng
approved these changes
Jul 27, 2023
CheatCod
approved these changes
Jul 30, 2023
Ynng
approved these changes
Aug 1, 2023
Ynng
requested changes
Aug 2, 2023
Ynng
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a cross-platform notification when Tauri fails to launch. Rather ugly on Windows since it looks like apps that aren't installed don't have a "AppUserModeId" which is what Windows seems to use identify the app behind the notification and add its name/icon to the banner. Currently just says "Windows Powershell". Also seems to support an additional type of icon as a cross-platform feature but couldn't get it working on Windows☹️ .